test(desktop): wait for narrative fixture workbar - #4970
Merged
Conversation
The narrative fixture exposed its transcript before its deferred workbar setup had selected Review. A test could open Trace in that gap and then lose selection when fixture setup completed. Wait for the seeded Git changes region before handing the page to tests. Fixes apache#4968 Generated-by: OpenAI Codex
me2seeks
approved these changes
Sep 8, 2026
me2seeks
left a comment
me2seeks
left a comment
Contributor
There was a problem hiding this comment.
Automated review by OpenAI Codex, operated by me2seeks, at 799c76e2e3bb343f2106ba8bc48d21a6b69fadb2. This is an automated technical assessment, not an independent human review. Approval is submitted at the operator's explicit direction.
No actionable findings. The turn-narrative producer seeds workbarTab=review only after deferred fixture application. Waiting for the localized Git changes region before handing the page to consumers closes the fixture/test ordering race without production synchronization, polling counters, or sleeps.
- Optimal for the actual problem: Yes; the change addresses the defect at its existing owner.
- Production code that can be deleted: None identified.
- Low-quality tests that can be deleted or replaced: None identified.
- Deeper refactor: No deeper refactor is needed.
- Ready to merge: Content is ready; merge remains conditional on current required checks and conflict state.
- Residual risks / verification: Read the exact fixture, seed producer, region copy, and consuming workbar test; required hosted test passed. Did not rerun Electron E2E locally. No protected-area effect identified in this diff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wait for the seeded Git changes panel to become visible before the narrative fixture hands its page to tests. This closes the initialization gap where the fixture could select Review after the usage action had already selected Trace.
Fixes #4968
Verification
npm exec -- biome check apps/desktop/e2e/fixtures.tsnpm --workspace @maka/desktop run build:workspace-deps && npm --workspace @maka/desktop run typechecknpm exec -w @maka/desktop -- playwright test --config e2e/playwright.config.ts e2e/session-workbar.spec.ts --grep "the composer usage action opens Task trace in the right workbar" --repeat-each=10(10 passed)git diff origin/main...HEAD --checkAI use
Tool(s) and scope: OpenAI Codex investigated the CI failure, implemented the fixture synchronization, and ran verification. The commit includes the required
Generated-by: OpenAI Codextrailer.Checklist
Does this PR entail a change in behavior?